jiajunwang commented on a change in pull request #1127:
URL: https://github.com/apache/helix/pull/1127#discussion_r448022030
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/ZkClientType.java
##########
@@ -25,18 +25,24 @@
* creation, callback functionality, and session management. But note that
this is more
* resource-heavy since it creates a dedicated ZK connection so should be
used sparingly only
* when the aforementioned features are needed.
+ *
+ * Valid on SINGLE_REALM only.
*/
DEDICATED,
Review comment:
Given the current situation that user still has an option to choose
between dedicated/shared clients when the realm mode is single realm, I agree
that we still need to keep the methods in the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
