jiajunwang commented on a change in pull request #1127:
URL: https://github.com/apache/helix/pull/1127#discussion_r447410549
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/ZkClientType.java
##########
@@ -25,18 +25,24 @@
* creation, callback functionality, and session management. But note that
this is more
* resource-heavy since it creates a dedicated ZK connection so should be
used sparingly only
* when the aforementioned features are needed.
+ *
+ * Valid on SINGLE_REALM only.
*/
DEDICATED,
Review comment:
> The user does have the ability to select the ZkClientType.
Sure. My question is that once a user selects a certain type, do they have
to specify a RealmMode in addition? Since based on your comment, it seems to be
pure overhead. Because if they select DEDICATED, then the real mode has to be
SINGLE_REALM.
I know this is for backward compatibility, so shall we just fill the
RealmMode for the user when they configure the client using ZkClientType? In
this case, we don't need the validation logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
