dasahcc commented on a change in pull request #1127:
URL: https://github.com/apache/helix/pull/1127#discussion_r448600530
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/GenericBaseDataAccessorBuilder.java
##########
@@ -82,38 +82,28 @@ protected RealmAwareZkClient
createZkClient(RealmAwareZkClient.RealmMode realmMo
switch (realmMode) {
case MULTI_REALM:
try {
- if (_zkClientType == ZkClientType.DEDICATED) {
- // Use a realm-aware dedicated zk client
- zkClient = DedicatedZkClientFactory.getInstance()
- .buildZkClient(connectionConfig, clientConfig);
- } else if (_zkClientType == ZkClientType.SHARED) {
- // Use a realm-aware shared zk client
- zkClient =
-
SharedZkClientFactory.getInstance().buildZkClient(connectionConfig,
clientConfig);
- } else {
- zkClient = new FederatedZkClient(connectionConfig, clientConfig);
- }
- } catch (IOException | InvalidRoutingDataException |
IllegalStateException e) {
+ zkClient = new FederatedZkClient(connectionConfig, clientConfig);
Review comment:
Sounds good. We need to clear deliver this to users. Then for the
change. I am totally fine with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
