NealSun96 opened a new pull request #1136:
URL: https://github.com/apache/helix/pull/1136
### Issues
- [x] My PR addresses the following Helix issues and references them in the
PR description:
Fixes #1133
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Currently, `getIdealAssignmentForWagedFullAuto()` gets its final resource
assignment results from the partition state mapping of output, which is
calculated within the best possible state calculation stage. However, the
partition state mapping contains the N+1 cases, which isn't suitable for
certain use cases.
We would like to allow this function to return an assignment result that's
based on the preference lists, which are closer to be the "calculation result"
done by Waged.
### Tests
- [x] The following is the result of the "mvn test" command on the
appropriate module:
```
[ERROR] Tests run: 1151, Failures: 1, Errors: 0, Skipped: 1, Time elapsed:
4,637.199 s <<< FAILURE! - in TestSuite
[ERROR]
testEnableCompressionResource(org.apache.helix.integration.TestEnableCompression)
Time elapsed: 229.89 s <<< FAILURE!
java.lang.AssertionError: expected:<true> but was:<false>
at
org.apache.helix.integration.TestEnableCompression.testEnableCompressionResource(TestEnableCompression.java:117)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestEnableCompression.testEnableCompressionResource:117
expected:<true> but was:<false>
[INFO]
[ERROR] Tests run: 1151, Failures: 1, Errors: 0, Skipped: 1
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:17 h
[INFO] Finished at: 2020-07-02T11:39:31-07:00
[INFO]
------------------------------------------------------------------------
```
Rerun
```
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
25.776 s - in org.apache.helix.integration.TestEnableCompression
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 31.768 s
[INFO] Finished at: 2020-07-02T11:40:52-07:00
[INFO]
------------------------------------------------------------------------
```
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in
their subject lines. In addition, my commits follow the guidelines from "[How
to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [x] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
