jiajunwang commented on a change in pull request #1136:
URL: https://github.com/apache/helix/pull/1136#discussion_r449211451
##########
File path: helix-core/src/main/java/org/apache/helix/util/HelixUtil.java
##########
@@ -177,6 +178,39 @@ public static String serializeByComma(List<String>
objects) {
String metadataStoreAddress, ClusterConfig clusterConfig,
List<InstanceConfig> instanceConfigs, List<String> liveInstances,
List<IdealState> idealStates, List<ResourceConfig> resourceConfigs) {
+ return getIdealAssignmentForWagedFullAutoImpl(metadataStoreAddress,
clusterConfig,
+ instanceConfigs, liveInstances, idealStates, resourceConfigs, true);
+ }
+
+ /**
+ * Returns the expected ideal ResourceAssignments for the given resources in
the cluster
+ * calculated using the read-only WAGED rebalancer. The returned result is
based on partition
+ * state mapping.
+ * @param metadataStoreAddress
+ * @param clusterConfig
+ * @param instanceConfigs
+ * @param liveInstances
+ * @param idealStates
+ * @param resourceConfigs
+ * @return
+ */
+ public static Map<String, ResourceAssignment>
getIdealPartitionMapForWagedFullAuto(
Review comment:
The names are not clear enough, IMO.
How about getTargetAssignmentForWagedFullAuto and
getImmediateAssignmentForWagedFullAutoImpl ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
