narendly commented on a change in pull request #1136:
URL: https://github.com/apache/helix/pull/1136#discussion_r449257772
##########
File path: helix-core/src/main/java/org/apache/helix/util/HelixUtil.java
##########
@@ -173,10 +174,43 @@ public static String serializeByComma(List<String>
objects) {
* @param resourceConfigs
* @return
*/
- public static Map<String, ResourceAssignment>
getIdealAssignmentForWagedFullAuto(
+ public static Map<String, ResourceAssignment>
getTargetAssignmentForWagedFullAuto(
Review comment:
Shouldn't we leave this unchanged since this is a public method and we
know there are users using this?
##########
File path: helix-core/src/main/java/org/apache/helix/util/HelixUtil.java
##########
@@ -173,10 +174,43 @@ public static String serializeByComma(List<String>
objects) {
* @param resourceConfigs
* @return
*/
- public static Map<String, ResourceAssignment>
getIdealAssignmentForWagedFullAuto(
+ public static Map<String, ResourceAssignment>
getTargetAssignmentForWagedFullAuto(
Review comment:
Should we leave this unchanged since this is a public method and we know
there are users using this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
