NealSun96 commented on a change in pull request #1136:
URL: https://github.com/apache/helix/pull/1136#discussion_r453791412
##########
File path: helix-core/src/main/java/org/apache/helix/util/HelixUtil.java
##########
@@ -173,10 +174,43 @@ public static String serializeByComma(List<String>
objects) {
* @param resourceConfigs
* @return
*/
- public static Map<String, ResourceAssignment>
getIdealAssignmentForWagedFullAuto(
+ public static Map<String, ResourceAssignment>
getTargetAssignmentForWagedFullAuto(
Review comment:
That's my initial thought too, which is why I kept the method name in my
initial commit.
However, keeping this name makes it hard to differentiate from the other
method (both are "ideal" assignments), and I liked Jiajun's new names. The only
current reference is the migration testing tool, which I think is fine to be
updated as Helix version is updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
