narendly commented on a change in pull request #1142:
URL: https://github.com/apache/helix/pull/1142#discussion_r453338650
##########
File path:
helix-core/src/main/java/org/apache/helix/task/AbstractTaskDispatcher.java
##########
@@ -745,7 +743,7 @@ protected void scheduleForNextTask(String job, JobContext
jobCtx, long now) {
}
}
- // add all partitions that have been tried maxNumberAttempts
+ // add all partitions that are given up
Review comment:
What is the distinction between "given up" and partitions that exceeded
the # of maximum attempts? Do you think we could clarify that here?
I have a feeling that "given up" might be too broad or abstract.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
