alirezazamani commented on a change in pull request #1142:
URL: https://github.com/apache/helix/pull/1142#discussion_r455399152
##########
File path:
helix-core/src/main/java/org/apache/helix/task/AbstractTaskDispatcher.java
##########
@@ -745,7 +743,7 @@ protected void scheduleForNextTask(String job, JobContext
jobCtx, long now) {
}
}
- // add all partitions that have been tried maxNumberAttempts
+ // add all partitions that are given up
Review comment:
Thanks for the comment. I added comments for more explanation.
Also I noticed the given up tasks has been already added in job dispatcher.
So we do not need to add the tasks again. However, we want to have a sanity
check to filter all of the tasks, regarding of their states, if they reached
their maximum number of attempts. Because it has been observed that sometimes,
the state of the task might be INIT or DROPPED or other states (if we have
pending messages) and we miss max number of attempts check for those tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
