narendly commented on a change in pull request #1142:
URL: https://github.com/apache/helix/pull/1142#discussion_r453339581
##########
File path:
helix-core/src/main/java/org/apache/helix/task/AbstractTaskDispatcher.java
##########
@@ -185,17 +185,13 @@ public void updatePreviousAssignedTasksStatus(
switch (currState) {
case RUNNING: {
TaskPartitionState nextState = TaskPartitionState.RUNNING;
- if (jobState == TaskState.TIMING_OUT) {
+ if (jobState == TaskState.TIMING_OUT || jobState ==
TaskState.TIMED_OUT
+ || jobState == TaskState.FAILING || jobState == TaskState.FAILED
+ || jobState == TaskState.ABORTED) {
Review comment:
Also just to confirm, this is to make sure that task states that are
stuck in RUNNING get updated to ABORTED?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
