narendly commented on a change in pull request #1142:
URL: https://github.com/apache/helix/pull/1142#discussion_r457136829
##########
File path:
helix-core/src/main/java/org/apache/helix/task/AbstractTaskDispatcher.java
##########
@@ -74,6 +75,12 @@ public void updatePreviousAssignedTasksStatus(
Set<Integer> skippedPartitions, WorkflowControllerDataProvider cache,
Map<String, Set<Integer>> tasksToDrop) {
+ // If a job is in the following states and contains running tasks, all of
the running tasks
+ // should go to the ABORTED states.
+ Set<TaskState> jobStatesForRunningTaskToAbortedState =
Review comment:
I think calling it `jobStatesForAbortingTasks` does the trick and is
shorter. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
