alirezazamani commented on a change in pull request #1142:
URL: https://github.com/apache/helix/pull/1142#discussion_r457601610
##########
File path:
helix-core/src/main/java/org/apache/helix/task/AbstractTaskDispatcher.java
##########
@@ -745,8 +748,12 @@ protected void scheduleForNextTask(String job, JobContext
jobCtx, long now) {
}
}
- // add all partitions that have been tried maxNumberAttempts
- protected static void addGiveupPartitions(Set<Integer> set, JobContext ctx,
+ // Add all partitions/tasks that are cannot be retried. These tasks are:
+ // 1- Task is in ABORTED or ERROR state.
+ // 2- Task has just gone to TIMED_OUT, ERROR or DROPPED states and has
reached to its
+ // maxNumberAttempts
+ // These tasks determine whether the job needs to FAILED or not.
+ protected static void addGiveUpPartitions(Set<Integer> set, JobContext ctx,
Review comment:
Done :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
