narendly commented on pull request #1157: URL: https://github.com/apache/helix/pull/1157#issuecomment-661278267
In the test testDuplicateMsg from TestRebalancePipeline, currently an invalid session id is used. The wrong session id makes the following test and assertion meaningless. This PR uses the correct session id liveInstances.get(0).getEphemeralOwner() instead. Also, we found a NPE thrown during the pipeline, causing the pipeline to stop, due to the missing thread pool in setAsyncTasksThreadPool. This PR works around the issue by giving it a thread pool and adds an issue reference in the comment block. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
