narendly commented on a change in pull request #1157:
URL: https://github.com/apache/helix/pull/1157#discussion_r457680264
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java
##########
@@ -45,10 +47,17 @@
import org.apache.helix.model.Message;
import org.apache.helix.model.Partition;
import org.testng.Assert;
+import org.testng.annotations.AfterClass;
import org.testng.annotations.Test;
public class TestRebalancePipeline extends ZkUnitTestBase {
private final String _className = getShortClassName();
+ private ExecutorService _executorService;
Review comment:
Should we not have this variable in the scope of the class? Since this
isn't being used throughout the class, we could just create the reference in
the test method and shut down at the very end of the method. That way, we don't
need to add the afterClass() method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
