narendly commented on a change in pull request #1199:
URL: https://github.com/apache/helix/pull/1199#discussion_r463888755
##########
File path: helix-core/src/main/java/org/apache/helix/InstanceType.java
##########
@@ -22,7 +22,7 @@
import java.util.Arrays;
import java.util.List;
-import org.apache.helix.monitoring.mbeans.MonitorDomainNames;
+import org.apache.helix.monitoring.common.mbeans.MonitorDomainNames;
Review comment:
Thanks for identifying the issue and proposing a potential solution.
However, I think the title of this PR/commit is a bit misleading - are we
removing any classes? I'm not seeing any files removed in this PR..
I think instead of moving dual-existent classes so that they have different
import paths, we should identify which classes both exist in both
metrics-common and helix-core, and just remove the ones in helix-core. They
were initially left in helix-core, but we should remove them clean since
they're causing issues. This way, we won't have to modify any package names and
the issue we get from duplicate classes at runtime will no longer be there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
