narendly commented on a change in pull request #1199:
URL: https://github.com/apache/helix/pull/1199#discussion_r463978956
##########
File path:
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterEventMonitor.java
##########
@@ -26,10 +26,10 @@
import com.codahale.metrics.Histogram;
import com.codahale.metrics.SlidingTimeWindowArrayReservoir;
-import org.apache.helix.monitoring.mbeans.dynamicMBeans.DynamicMBeanProvider;
-import org.apache.helix.monitoring.mbeans.dynamicMBeans.DynamicMetric;
-import org.apache.helix.monitoring.mbeans.dynamicMBeans.HistogramDynamicMetric;
-import org.apache.helix.monitoring.mbeans.dynamicMBeans.SimpleDynamicMetric;
+import
org.apache.helix.monitoring.common.mbeans.dynamicMBeans.DynamicMBeanProvider;
+import org.apache.helix.monitoring.common.mbeans.dynamicMBeans.DynamicMetric;
+import
org.apache.helix.monitoring.common.mbeans.dynamicMBeans.HistogramDynamicMetric;
+import
org.apache.helix.monitoring.common.mbeans.dynamicMBeans.SimpleDynamicMetric;
Review comment:
The original package naming was intentional in order to not cause
existing applications to have to change import statements (code change). Why is
this needed? Are users importing multiple modules at the same time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
