pkuwm commented on a change in pull request #1199:
URL: https://github.com/apache/helix/pull/1199#discussion_r463906943
##########
File path: helix-core/src/main/java/org/apache/helix/InstanceType.java
##########
@@ -22,7 +22,7 @@
import java.util.Arrays;
import java.util.List;
-import org.apache.helix.monitoring.mbeans.MonitorDomainNames;
+import org.apache.helix.monitoring.common.mbeans.MonitorDomainNames;
Review comment:
I guess you missed something about the problem. There are no conflicting
classes in helix-core. All classes are unique/only in helix codebase. The
problem is, when we package the helix jars, the dependent subproject's classes
are packaged into helix-core.jar: all classes in module helix-core and its
dependencies that match `org.apache.helix.*` are all packaged to
helix-core.jar. Then there are duplicate classes from
metrics-common.jar/zookeeper-api.jar/helix-core.jar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
