mgao0 commented on a change in pull request #1187:
URL: https://github.com/apache/helix/pull/1187#discussion_r465214147
##########
File path:
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
##########
@@ -0,0 +1,190 @@
+package org.apache.helix.monitoring.mbeans;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+import javax.management.JMException;
+import javax.management.MalformedObjectNameException;
+import javax.management.ObjectName;
+
+import com.codahale.metrics.Histogram;
+import com.codahale.metrics.SlidingTimeWindowArrayReservoir;
+import com.google.common.collect.MapDifference;
+import com.google.common.collect.Maps;
+import org.apache.helix.model.CustomizedView;
+import org.apache.helix.model.Partition;
+import org.apache.helix.monitoring.mbeans.dynamicMBeans.DynamicMBeanProvider;
+import org.apache.helix.monitoring.mbeans.dynamicMBeans.DynamicMetric;
+import org.apache.helix.monitoring.mbeans.dynamicMBeans.HistogramDynamicMetric;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testng.collections.Lists;
+
+
+public class CustomizedViewMonitor extends DynamicMBeanProvider {
+ private static Logger LOG =
LoggerFactory.getLogger(CustomizedViewMonitor.class);
+
+ private static final String MBEAN_DESCRIPTION = "Helix Customized View
Aggregation Monitor";
+ private final String _clusterName;
+ private final String _sensorName;
+ private HistogramDynamicMetric _updateToAggregationLatencyGauge;
+
+ public CustomizedViewMonitor(String clusterName) {
+ _clusterName = clusterName;
+ _sensorName =
+ String.format("%s.%s", MonitorDomainNames.RoutingTableProvider.name(),
_clusterName);
+ _updateToAggregationLatencyGauge = new
HistogramDynamicMetric("UpdateToAggregationLatencyGauge",
+ new Histogram(
+ new SlidingTimeWindowArrayReservoir(getResetIntervalInMs(),
TimeUnit.MILLISECONDS)));
+ }
+
+ @Override
+ public DynamicMBeanProvider register() throws JMException {
+ List<DynamicMetric<?, ?>> attributeList = new ArrayList<>();
+ attributeList.add(_updateToAggregationLatencyGauge);
+ doRegister(attributeList, MBEAN_DESCRIPTION, getMBeanName());
+ return this;
+ }
+
+ private ObjectName getMBeanName() throws MalformedObjectNameException {
+ return new ObjectName(String
+ .format("%s:%s=%s", MonitorDomainNames.CustomizedView.name(),
"Cluster", _clusterName));
+ }
+
+ @Override
+ public String getSensorName() {
+ return _sensorName;
+ }
+
+ private void recordUpdateToAggregationLatency(long latency) {
+ if (_updateToAggregationLatencyGauge != null) {
+ _updateToAggregationLatencyGauge.updateValue(latency);
+ }
+ }
+
+ /**
+ * Find updated customized states and report the aggregation latency of each
customized state
+ * @param updatedCustomizedViews Customized views that have been updated,
obtained from CustomizedStateOutput
+ * @param curCustomizedViews Current customized view values from the
CustomizedViewCache
+ * @param updatedStartTimestamps All customized state START_TIME property
values from CustomizedStateOutput
+ * @param updateSuccess If the customized view update to ZK is successful or
not
+ * @param endTime The timestamp when the new customized view is updated to ZK
+ */
+ public void reportLatency(List<CustomizedView> updatedCustomizedViews,
Review comment:
These events are put into a thread pool for async execution, but the
parameters we put in are all hard copied so they won't interfere with each
other. So each event is independent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
