mgao0 commented on a change in pull request #1187:
URL: https://github.com/apache/helix/pull/1187#discussion_r466643221
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateComputationStage.java
##########
@@ -86,6 +86,9 @@ private void updateCustomizedStates(String instanceName,
String customizedStateT
customizedStateOutput
.setCustomizedState(customizedStateType, resourceName,
partition, instanceName,
customizedState.getState(partitionName));
+ customizedStateOutput
+ .setStartTime(customizedStateType, resourceName, partition,
instanceName,
+ String.valueOf(customizedState.getStartTime(partitionName)));
Review comment:
Good suggestion. I'll keep the long type, and save the two conversions
of types for saving to and retrieving from the map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
