mgao0 commented on a change in pull request #1187:
URL: https://github.com/apache/helix/pull/1187#discussion_r465920642
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/stages/TestCustomizedViewStage.java
##########
@@ -112,4 +110,60 @@ public void testCachedCustomizedViews() throws Exception {
deleteLiveInstances(clusterName);
deleteCluster(clusterName);
}
+
+ @Test
+ public void testLatencyMetricReporting() throws Exception {
+ String clusterName = "CLUSTER_" + TestHelper.getTestMethodName();
+
+ HelixDataAccessor accessor =
+ new ZKHelixDataAccessor(clusterName, new
ZkBaseDataAccessor<>(_gZkClient));
+ HelixManager manager = new DummyClusterManager(clusterName, accessor);
+
+ // ideal state: node0 is MASTER, node1 is SLAVE
+ // replica=2 means 1 master and 1 slave
+ setupIdealState(clusterName, new int[]{0, 1}, new String[]{"TestDB"}, 1,
2);
+ setupLiveInstances(clusterName, new int[]{0, 1});
+ setupStateModel(clusterName);
+
+ ClusterEvent event = new ClusterEvent(clusterName,
ClusterEventType.Unknown);
+ ResourceControllerDataProvider cache = new
ResourceControllerDataProvider(clusterName);
+ event.addAttribute(AttributeName.helixmanager.name(), manager);
+ event.addAttribute(AttributeName.ControllerDataProvider.name(), cache);
+
+ CustomizedStateConfig config = new CustomizedStateConfig();
+ List<String> aggregationEnabledTypes = new ArrayList<>();
+ aggregationEnabledTypes.add(CUSTOMIZED_STATE_NAME);
+ config.setAggregationEnabledTypes(aggregationEnabledTypes);
+
+ PropertyKey.Builder keyBuilder = accessor.keyBuilder();
+ accessor.setProperty(keyBuilder.customizedStateConfig(), config);
+
+ CustomizedState customizedState = new CustomizedState(RESOURCE_NAME);
+ customizedState.setState(PARTITION_NAME, "STATE");
+ customizedState.setStartTime(PARTITION_NAME, 0);
+ accessor.setProperty(
+ keyBuilder.customizedState(INSTANCE_NAME, CUSTOMIZED_STATE_NAME,
RESOURCE_NAME),
+ customizedState);
+
+ Pipeline dataRefresh = new Pipeline();
+ dataRefresh.addStage(new ReadClusterDataStage());
+ runPipeline(event, dataRefresh);
+ runStage(event, new ResourceComputationStage());
+ runStage(event, new CustomizedStateComputationStage());
+ runStage(event, new CustomizedViewAggregationStage());
+
+ ObjectName objectName = new ObjectName(String
+ .format("%s:%s=%s", MonitorDomainNames.CustomizedView.name(),
"Cluster", clusterName));
+ ObjectInstance monitor = _server.getObjectInstance(objectName);
+ Assert.assertNotNull(monitor);
+ TestHelper.verify(() -> (long) _server.getAttribute(objectName,
+ CustomizedViewMonitor.UPDATE_TO_AGGREGATION_LATENCY_GAUGE + ".Max") ==
0,
Review comment:
Good catch. I made a mistake here, it should be not equal to 0, which
means there is a latency data point reported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
