mgao0 commented on a change in pull request #1187:
URL: https://github.com/apache/helix/pull/1187#discussion_r466644724
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateComputationStage.java
##########
@@ -86,6 +86,9 @@ private void updateCustomizedStates(String instanceName,
String customizedStateT
customizedStateOutput
.setCustomizedState(customizedStateType, resourceName,
partition, instanceName,
customizedState.getState(partitionName));
+ customizedStateOutput
Review comment:
I added another parameter to setCustomizedState() and now this method
can set both fields.
Originally I didn't want to change the interface of setCustomizedState()
because it is a public method. But I think your comment also makes sense since
we are going to keep this start time field, and this is the only place
setCustomizedState() is called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
