NealSun96 commented on a change in pull request #1231:
URL: https://github.com/apache/helix/pull/1231#discussion_r467317342
##########
File path: helix-core/src/main/java/org/apache/helix/task/JobDispatcher.java
##########
@@ -87,9 +87,10 @@ public ResourceAssignment
processJobStatusUpdateAndAssignment(String jobName,
TaskState jobState = workflowCtx.getJobState(jobName);
// The job is already in a final state (completed/failed).
if (workflowState == TaskState.FAILED || workflowState ==
TaskState.COMPLETED
- || jobState == TaskState.FAILED || jobState == TaskState.COMPLETED) {
+ || jobState == TaskState.FAILED || jobState == TaskState.COMPLETED
+ || jobState == TaskState.TIMED_OUT) {
LOG.info(String.format(
- "Workflow %s or job %s is already failed or completed, workflow
state (%s), job state (%s), clean up job IS.",
+ "Workflow %s or job %s is already in final state, workflow state
(%s), job state (%s), clean up job IS.",
Review comment:
The thing is Workflow = timed_out is not checked here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
