NealSun96 commented on a change in pull request #1231:
URL: https://github.com/apache/helix/pull/1231#discussion_r468221660
##########
File path: helix-core/src/main/java/org/apache/helix/task/JobConfig.java
##########
@@ -147,10 +147,17 @@
StartTime,
/**
- * The expiration time for the job
+ * The expiration time for the job if it's completed; once the expiry is
reached and the job is
+ * completed, the job will be purged
*/
Expiry,
+ /**
+ * The expiration time for the job if it's failed or timed out; once the
expiry is reached and
+ * the job has failed or timed out, the job will be purged
+ */
+ TerminalStateExpiry,
Review comment:
@dasahcc The default behavior being not purging is already implemented:
not specifying the expiry = not purging; we don't need an extra boolean flag.
I understand where your came from, but the flexibility should be a good
thing; after all, wouldn't users be more inclined to investigate
failed/timed-out jobs comparing to completed jobs? The investigation
flexibility should be more suited for the terminal state expiry.
For what its worth, if a user want to "keep an eye out for Job0 if it fails,
but don't care if the other jobs fail", then it's easy to config that way: give
Job0 no expiry (not purging), and give other jobs an expiry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
