dasahcc commented on a change in pull request #1231:
URL: https://github.com/apache/helix/pull/1231#discussion_r468196442
##########
File path: helix-core/src/main/java/org/apache/helix/task/JobConfig.java
##########
@@ -147,10 +147,17 @@
StartTime,
/**
- * The expiration time for the job
+ * The expiration time for the job if it's completed; once the expiry is
reached and the job is
+ * completed, the job will be purged
*/
Expiry,
+ /**
+ * The expiration time for the job if it's failed or timed out; once the
expiry is reached and
+ * the job has failed or timed out, the job will be purged
+ */
+ TerminalStateExpiry,
Review comment:
> The current `expiry` config we're using is on per-job level, though. I
imagine there's a reason behind that?
At job level is make sense that different job could have different time to
persist for further investigation.
@alirezazamani And we dont have to make the behavior to fine-grained at job
level. Because we defined the default behavior not purge failed/timeout jobs
gloabally. That's why I am suggesting not adding the options at job level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
