dasahcc commented on a change in pull request #1231:
URL: https://github.com/apache/helix/pull/1231#discussion_r468184045
##########
File path: helix-core/src/main/java/org/apache/helix/task/JobConfig.java
##########
@@ -147,10 +147,17 @@
StartTime,
/**
- * The expiration time for the job
+ * The expiration time for the job if it's completed; once the expiry is
reached and the job is
+ * completed, the job will be purged
*/
Expiry,
+ /**
+ * The expiration time for the job if it's failed or timed out; once the
expiry is reached and
+ * the job has failed or timed out, the job will be purged
+ */
+ TerminalStateExpiry,
Review comment:
Then there could be too many expiry to configured by user. Even if we
want to support this at per job level, we need a boolean flag to show whether
we should clean them after expiry when it fails or timed out. From time
perspective, I dont think user has any difference with time number.
But from user migration perspective, adding to job level is very cost and
roll out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
