NealSun96 commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r478728537
##########
File path:
helix-core/src/test/java/org/apache/helix/task/TestGetLastScheduledTaskExecInfo.java
##########
@@ -75,6 +75,10 @@ public void testGetLastScheduledTaskExecInfo() throws
Exception {
// Stop and delete the queue
_driver.stop(queueName);
+ TestHelper.verify(() -> {
Review comment:
Test bug fix: if the job queue is deleted right after stopping, it is
possible that current states are not dropped on the instances. This is because
the RUNNING to STOPPED message may still be pending when STOPPED to DROPPED
message is generated, meaning the latter message is not sent; however, during
the next pipeline cycle the job queue may have been deleted already, so the
STOPPED to DROPPED message is never generated again. Adding this check to make
the test non-flaky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
