NealSun96 commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r478727494
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/stages/TestQuotaConstraintSkipWorkflowAssignment.java
##########
@@ -51,12 +51,11 @@ public void beforeClass() throws Exception {
public void testQuotaConstraintSkipWorkflowAssignment() throws Exception {
ClusterEvent event = new ClusterEvent(ClusterEventType.Unknown);
WorkflowControllerDataProvider cache = new
WorkflowControllerDataProvider(CLUSTER_NAME);
- JobConfig.Builder job = new JobConfig.Builder();
-
- job.setJobCommandConfigMap(Collections.singletonMap(MockTask.JOB_DELAY,
"100000"));
TaskDriver driver = new TaskDriver(_manager);
for (int i = 0; i < 10; i++) {
Workflow.Builder workflow = new Workflow.Builder("Workflow" + i);
+ JobConfig.Builder job = new JobConfig.Builder();
Review comment:
Test bug fix: the old logic causes each job to accumulate the tasks
assigned to the previous job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
