NealSun96 commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r478726856
##########
File path:
helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java
##########
@@ -322,64 +328,6 @@ private void processJob(String job, CurrentStateOutput
currentStateOutput,
}
}
- /**
- * Posts new job to cluster
- */
- private void scheduleSingleJob(String jobResource, JobConfig jobConfig) {
- HelixAdmin admin = _manager.getClusterManagmentTool();
-
- IdealState jobIS = admin.getResourceIdealState(_manager.getClusterName(),
jobResource);
- if (jobIS != null) {
- LOG.info("Job " + jobResource + " idealstate already exists!");
- return;
- }
-
- // Set up job resource based on partitions from target resource
-
- // Create the UserContentStore for the job first
- TaskUtil.createUserContent(_manager.getHelixPropertyStore(), jobResource,
Review comment:
This line is already done in processJob() when the job is first started,
making this logic redundant. Therefore it's removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
