NealSun96 commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r482249925
##########
File path:
helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java
##########
@@ -290,7 +297,6 @@ private void scheduleJobs(String workflow, WorkflowConfig
workflowCfg,
// Time is not ready. Set a trigger and update the start time.
// Check if the job is ready to be executed.
if (System.currentTimeMillis() >= workflowCtx.getJobStartTime(job)) {
- scheduleSingleJob(job, jobConfig);
Review comment:
The only line that was kept in scheduleSingleJob() was the line about
creating job context, however, that is already done in processJob. You could
check my comment in scheduleSingleJob.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
