narendly commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r483231899
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java
##########
@@ -185,4 +232,21 @@ private void addPartition(String partition, String
resourceName, Map<String, Res
resource.addPartition(partition);
}
+
+ private void addResourceConfigToResourceMap(String resourceName,
ResourceConfig resourceConfig,
Review comment:
So it seems that all `WorkflowConfigs` and `JobConfigs` are being added
to both `resourceMap` and `resourceToRebalance`.
If my understanding of the pipeline is up-to-date, the reason we have two
different maps is for the resource pipeline to filter out TASK resources and
save them into `resourceToRebalance`.
So
- `resourceMap`: all resources
- `resourceToRebalance`: all resources - TASK resources
Now, for the task pipeline, do we need to keep both maps? It seems that
you're doing the filtering by populating things from `ResourceConfigs` only +
`currentStates` to `resourceToRebalance`. With that said, what's the point of
populating/keeping `resourceMap`? Does `resourceMap` still contain ALL
resources for the task pipeline as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
