narendly commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r483236269



##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java
##########
@@ -762,9 +719,6 @@ public void deleteAndWaitForCompletion(String workflow, 
long timeout)
 
     // Deletion failed: check which step of deletion failed to complete and 
create an error message
     StringBuilder failed = new StringBuilder();
-    if (baseDataAccessor.exists(idealStatePath, AccessOption.PERSISTENT)) {
-      failed.append("IdealState ");
-    }

Review comment:
       Should we keep this for backward-compatibility? For legacy or existing 
workflows/jobs, how will their IdealStates be removed? Who will remove them?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to