narendly commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r483236666
##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
##########
@@ -594,58 +594,6 @@ public static PropertyKey getWorkflowConfigKey(final
HelixDataAccessor accessor,
return accessor.keyBuilder().resourceConfig(workflow);
}
- /**
- * Cleans up IdealState and external view associated with a job.
- * @param accessor
- * @param job
- * @return True if remove success, otherwise false
- */
- protected static boolean cleanupJobIdealStateExtView(final HelixDataAccessor
accessor,
- String job) {
- return cleanupIdealStateExtView(accessor, job);
- }
Review comment:
I wonder for backward-compatibility, if we should leave this in for the
time being and just mark them as deprecated. For the existing workload?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
