narendly commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r483275335
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java
##########
@@ -185,4 +232,21 @@ private void addPartition(String partition, String
resourceName, Map<String, Res
resource.addPartition(partition);
}
+
+ private void addResourceConfigToResourceMap(String resourceName,
ResourceConfig resourceConfig,
Review comment:
> With that said, your assessment on `resourceToRebalance` isn't
entirely accurate: when the pipeline is for tasks, `resourceToRebalance`
contains all the task resources as well.
Could you pinpoint what's amiss here? Do you mean to say that for the
resource pipeline, resourceToRebalance also contains task resources? For the
task pipeline, should resourceMap contain all resources and resourceToRebalance
contain only task resources?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
