NealSun96 commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r483839440



##########
File path: 
helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java
##########
@@ -185,4 +232,21 @@ private void addPartition(String partition, String 
resourceName, Map<String, Res
     resource.addPartition(partition);
 
   }
+
+  private void addResourceConfigToResourceMap(String resourceName, 
ResourceConfig resourceConfig,

Review comment:
       I see that I had a bit misunderstanding on your original message: you're 
right that in the resource pipeline, `resourceToRebalance` doesn't contain task 
resources; in the task pipeline, `resourceToRebalance` only contains task 
resources. This behavior remains the same after IS removal (`resourceMap` 
contains all resources).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to