NealSun96 commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r483273500
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java
##########
@@ -185,4 +232,21 @@ private void addPartition(String partition, String
resourceName, Map<String, Res
resource.addPartition(partition);
}
+
+ private void addResourceConfigToResourceMap(String resourceName,
ResourceConfig resourceConfig,
Review comment:
This PR doesn't change any of the map populating behavior: if a
workflow/job was added to both maps in the past (based on IS), now they are
added to both maps based on configs. - [With that said, your assessment on
`resourceToRebalance` isn't entirely accurate: when the pipeline is for tasks,
`resourceToRebalance` contains all the task resources as well.]
The reason why we have both maps is because of the usages in other stages.
For example, in `CurrentStateComputationStage`, task resources need to be
present in both maps. There's definitely room for improvement in this aspect,
but that would perhaps be in another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
