kaisun2000 commented on a change in pull request #1227:
URL: https://github.com/apache/helix/pull/1227#discussion_r489852639
##########
File path: helix-core/src/test/java/org/apache/helix/common/ZkTestBase.java
##########
@@ -719,6 +722,20 @@ public void cleanupLiveInstanceOwners() {
clientMap.clear();
}
_liveInstanceOwners.clear();
+
+ // wait 2 seconds for threads to be teared down.
+ // this reduce false alert.
+ Thread.sleep(1000);
+ boolean status = false;
+ try {
+ status = ThreadLeakageChecker.afterClassCheck(testClassName);
+ } catch (Exception e) {
+ System.out.println("ThreadLeakageChecker exception:" +
e.getStackTrace());
+ }
+ // Assert here does not work.
+ if (!status) {
+ System.out.println("---------- Test Class " + testClassName + " thread
leakage detected! ---------------");
Review comment:
This is going to keep the test continue to execute. Killing thread is a
little bit dangerous as out detection logic may not 100% right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
