kaisun2000 commented on a change in pull request #1227:
URL: https://github.com/apache/helix/pull/1227#discussion_r475814065
##########
File path:
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
##########
@@ -236,6 +239,9 @@ protected synchronized boolean verifyState() {
idealStates.entrySet()
.removeIf(pair ->
pair.getValue().getStateModelDefRef().equals(TaskConstants.STATE_MODEL_NAME));
+ if (_isLogMore) {
+ System.out.println("---- before verify instances !");
+ }
Review comment:
This is not production code, they are only in verifier which is test
utility I believe. The usage is to nail down how long does it take to wait so
that we can tune the timeout of test. In github, some operations are fast (say
starting Zookeeper) while some are slow (like refresh cache).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
