kaisun2000 commented on a change in pull request #1227:
URL: https://github.com/apache/helix/pull/1227#discussion_r475810452
##########
File path: helix-core/src/test/java/org/apache/helix/common/ZkTestBase.java
##########
@@ -719,6 +722,20 @@ public void cleanupLiveInstanceOwners() {
clientMap.clear();
}
_liveInstanceOwners.clear();
+
+ // wait 2 seconds for threads to be teared down.
+ // this reduce false alert.
+ Thread.sleep(1000);
Review comment:
This does not apply here. Tearing down thread is async to thread
shutdown by the Java virtual machine. There is not way for us to check when the
Java virtual machine really tear it down.
that said, I found by practice, waiting 2 sec does not really help much
either. I will remove it a little bit later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
