kaisun2000 commented on a change in pull request #1227:
URL: https://github.com/apache/helix/pull/1227#discussion_r476894932
##########
File path:
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -623,6 +623,13 @@ void reset() {
}
}
+ // some thing like STATE_TRANSITION.Key specific pool are not shut down.
+ for (String msgType : _executorMap.keySet()) {
+ ExecutorService pool = _executorMap.remove(msgType);
Review comment:
https://github.com/apache/helix/issues/1245.
HelixTaskExecutor does not shutdown STATE_TRANSITION.Key specific pool. That
is the root cause. This has thread leaking in production environment if the
msgtype-resourcekey feature is enabled when zk session expires.
In sum, these STATE_TRANSITIONLKEY pool should also be closed. But the
customer created ones should not be shutdown,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
