xyuanlu commented on a change in pull request #1415:
URL: https://github.com/apache/helix/pull/1415#discussion_r495425668
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java
##########
@@ -599,4 +610,12 @@ private int constructOptions(PropertyType type) {
List<DataUpdater<ZNRecord>> updaters, int options) {
return _baseDataAccessor.updateChildren(paths, updaters, options);
}
+
+ private void validateBucketizedEnabled(String path, boolean isRead) {
+ if (!BUCKETIZE_ZNRECORD_ENABLED) {
+ throw new HelixMetaDataAccessException(
+ "Can't " + (isRead ? "read" : "write") + " bucktized ZNode " + path
+ + " because Bucktize feature is not enabled. Please check ZK
system property 'zk.bucketize.znrecord.enabled' .");
Review comment:
Are you suggesting we read the config every time? We could if the config
need to be dynamically changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
