xyuanlu commented on a change in pull request #1415:
URL: https://github.com/apache/helix/pull/1415#discussion_r495425901
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java
##########
@@ -427,8 +437,9 @@ public boolean removeProperty(PropertyKey key) {
int bucketSize = property.getBucketSize();
if (bucketSize > 0) {
- // TODO: fix this if record.id != pathName
String childPath = parentPath + "/" + record.getId();
+ validateBucketizedEnabled(childPath, true /*isRead*/);
Review comment:
I personally feel that when reading the code without compiler, having
comment like this for boolean value is helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
