xyuanlu commented on a change in pull request #1415:
URL: https://github.com/apache/helix/pull/1415#discussion_r495426404
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java
##########
@@ -143,6 +147,7 @@ public boolean createMaintenance(MaintenanceSignal
maintenanceSignal) {
case EXTERNALVIEW:
// check if bucketized
if (value.getBucketSize() > 0) {
+ validateBucketizedEnabled(path, false /*isRead*/);
Review comment:
Please correct me if I am wrong.
I think we could use the existing bucketized node handling branch if added
in ZKHelixDataAccessor for minion code change. Checking in baceAccessor might
require more code change and branching.
Also we need to touch multiple places -- ZkBaseDataAccessor.get/setData
ZkBaseDataAccessor.get/setChildren() and ZkBaseDataAccessor.update().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
