alirezazamani commented on a change in pull request #1468:
URL: https://github.com/apache/helix/pull/1468#discussion_r510297485
##########
File path: helix-core/src/main/java/org/apache/helix/PropertyPathBuilder.java
##########
@@ -169,17 +170,16 @@
"/{clusterName}/PROPERTYSTORE/TaskRebalancer/{workflowName}/Context");
// Old
// WorkflowContext
// path
- addEntry(PropertyType.TASK_CONFIG_ROOT, 1, "/{clusterName}/CONFIGS/TASK");
- addEntry(PropertyType.WORKFLOW_CONFIG, 3,
- "/{clusterName}/CONFIGS/TASK/{workflowName}/{workflowName}");
- addEntry(PropertyType.JOB_CONFIG, 4,
- "/{clusterName}/CONFIGS/TASK/{workflowName}/{jobName}/{jobName}");
+ addEntry(PropertyType.TASK_CONFIG_ROOT, 1,
"/{clusterName}/CONFIGS/RESOURCE");
Review comment:
Added a TODO in case we want to change it in the future. I think for
performance reasons, we want to keep the structure as it is.
##########
File path: helix-core/src/main/java/org/apache/helix/task/JobContext.java
##########
@@ -313,4 +313,12 @@ public long getExecutionStartTime() {
}
return map;
}
+
+ /**
+ * Remove the task from the map field of job context.
+ * @param taskNumber
+ */
+ public void removeTask(int taskNumber) {
Review comment:
Done.
##########
File path: helix-core/src/main/java/org/apache/helix/task/JobDispatcher.java
##########
@@ -478,4 +482,61 @@ private TaskAssignmentCalculator
getAssignmentCalculator(JobConfig jobConfig,
}
return new FixedTargetTaskAssignmentCalculator(assignableInstanceManager);
}
+
+ /**
+ * Find the tasks that have been removed from job config, ass them to
tasksToDrop. If task's
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
