alirezazamani commented on a change in pull request #1468:
URL: https://github.com/apache/helix/pull/1468#discussion_r510353381
##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java
##########
@@ -699,6 +798,73 @@ private void addTaskToJobConfig(String workflowName,
String jobName, TaskConfig
throw new TimeoutException("An unexpected issue happened while task being
added to the job!");
}
+ /**
+ * A helper method which deletes an existing task from the job config and
verifies if task is
+ * deleted from the context by the controller.
+ * @param workflowName
+ * @param jobName
+ * @param taskID
+ * @param endTime
+ * @throws InterruptedException
+ * @throws TimeoutException
+ */
+ private void deleteTaskFromJobConfig(String workflowName, String jobName,
String taskID,
Review comment:
So they seem to be similar but they are different. Aside from the logs
and updaters which are different, in one of them we add a task to config and
then check if it is being added to context by the controller by polling. In
another one, we delete from config and make sure it is being deleted by the
controller from the context by polling. Anyways following your comment I did a
few simplifications on add API. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
