alirezazamani commented on a change in pull request #1468:
URL: https://github.com/apache/helix/pull/1468#discussion_r511684304
##########
File path: helix-core/src/main/java/org/apache/helix/task/JobDispatcher.java
##########
@@ -238,6 +238,10 @@ private ResourceAssignment computeResourceMapping(String
jobResource,
updateInstanceToTaskAssignmentsFromContext(jobCtx,
currentInstanceToTaskAssignments);
+ // Find the tasks that have been removed form the config, add them to
TasksToDrop
+ handleDeletedTasks(jobResource, jobCfg, jobCtx,
currentInstanceToTaskAssignments, tasksToDrop,
Review comment:
As we discussed offline, move the detection part in
taskAssignmentCalculator. Now it works for targeted jobs as well in case the
target DB shrinks. Now the logic is more general.
##########
File path: helix-core/src/main/java/org/apache/helix/task/JobDispatcher.java
##########
@@ -238,6 +238,10 @@ private ResourceAssignment computeResourceMapping(String
jobResource,
updateInstanceToTaskAssignmentsFromContext(jobCtx,
currentInstanceToTaskAssignments);
+ // Find the tasks that have been removed form the config, add them to
TasksToDrop
+ handleDeletedTasks(jobResource, jobCfg, jobCtx,
currentInstanceToTaskAssignments, tasksToDrop,
Review comment:
As we discussed offline, moved the detection part in
taskAssignmentCalculator. Now it works for targeted jobs as well in case the
target DB shrinks. Now the logic is more general.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
