alirezazamani commented on a change in pull request #1468:
URL: https://github.com/apache/helix/pull/1468#discussion_r510333534
##########
File path: helix-core/src/main/java/org/apache/helix/task/JobDispatcher.java
##########
@@ -238,6 +238,10 @@ private ResourceAssignment computeResourceMapping(String
jobResource,
updateInstanceToTaskAssignmentsFromContext(jobCtx,
currentInstanceToTaskAssignments);
+ // Find the tasks that have been removed form the config, add them to
TasksToDrop
+ handleDeletedTasks(jobResource, jobCfg, jobCtx,
currentInstanceToTaskAssignments, tasksToDrop,
Review comment:
The issue with moving it as part of
taskAssignmentCal.getAllTaskPartitions is that the outcome of that function
would have some effect on the job and workflow status. We need to consider all
the tasks unless it is completely DROPPED from the current state, then we can
make sure that currentState has been cleaned up and it will not cause quota
leakage later. So I think it makes more sense to have the task in
allPartitions, and when we are sure that currentState is DROPPED then we just
remove the task from context. In the future pipeline then it will not have any
effect because tasks would not show up in allPartitions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
