dasahcc commented on a change in pull request #1487:
URL: https://github.com/apache/helix/pull/1487#discussion_r514598225
##########
File path: helix-core/src/main/java/org/apache/helix/util/HelixUtil.java
##########
@@ -470,11 +471,26 @@ public static int getSystemPropertyAsInt(String
propertyKey, int propertyDefault
}
/**
- * Get the value of system property
+ * Get the boolean value of system property
* @param propertyKey
* @param propertyDefaultValue
* @return
*/
+ public static boolean getSystemPropertyAsBoolean(String propertyKey, String
propertyDefaultValue) {
Review comment:
+1. Unless you need some error handling in the function.
##########
File path: helix-common/src/main/java/org/apache/helix/SystemPropertyKeys.java
##########
@@ -82,4 +82,6 @@
// System Property Metadata Store Directory Server endpoint key
public static final String MSDS_SERVER_ENDPOINT_KEY =
MetadataStoreRoutingConstants.MSDS_SERVER_ENDPOINT_KEY;
+
+ public static final String STATEUPDATEUTIL_ERROR_LOG_ENABLED =
"helix.StateUpdateUtil.errorLog.enabled";
Review comment:
We have a class ZkSystemPropertyKeys to hold this kind of system
property. Please put this there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
