kaisun2000 commented on a change in pull request #1487:
URL: https://github.com/apache/helix/pull/1487#discussion_r520886902



##########
File path: helix-core/src/main/java/org/apache/helix/util/StatusUpdateUtil.java
##########
@@ -560,6 +556,10 @@ void publishStatusUpdateRecord(ZNRecord record, Message 
message, Level level,
    */
   void publishErrorRecord(ZNRecord record, String instanceName, String 
updateSubPath,
       String updateKey, String sessionId, HelixDataAccessor accessor, boolean 
isController) {
+    _logger.error("StatusUpdate Error record: {}", record);

Review comment:
       This is not a concern. Previously the issue is that N participant would 
write the log to one Zk quorum at the same time repeatedly. Here, we are 
writing to N participant at the same time. If this is a concern, we need to 
revisit all the participant side logging then.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to