kaisun2000 commented on a change in pull request #1487:
URL: https://github.com/apache/helix/pull/1487#discussion_r520747669
##########
File path: helix-common/src/main/java/org/apache/helix/SystemPropertyKeys.java
##########
@@ -82,4 +82,6 @@
// System Property Metadata Store Directory Server endpoint key
public static final String MSDS_SERVER_ENDPOINT_KEY =
MetadataStoreRoutingConstants.MSDS_SERVER_ENDPOINT_KEY;
+
+ public static final String STATEUPDATEUTIL_ERROR_LOG2ZK_ENABLED =
"helix.StateUpdateUtil.errorLog.enabled";
Review comment:
Can you illustrate the idea how to make it enum? Something like
```
enum STATEUPDATE_ERROR_REPORTING_CHANNEL {
LOG4J,
LOG2ZK
};
```
and in the system property,
`public static final String STATEUPDATEUTIL_ERROR_LOG2ZK_ENABLED = <enum
value>`;
then we will convert the system property to enum value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
