pkuwm commented on a change in pull request #1487:
URL: https://github.com/apache/helix/pull/1487#discussion_r520850428
##########
File path: helix-core/src/main/java/org/apache/helix/util/StatusUpdateUtil.java
##########
@@ -560,6 +556,10 @@ void publishStatusUpdateRecord(ZNRecord record, Message
message, Level level,
*/
void publishErrorRecord(ZNRecord record, String instanceName, String
updateSubPath,
String updateKey, String sessionId, HelixDataAccessor accessor, boolean
isController) {
+ _logger.error("StatusUpdate Error record: {}", record);
Review comment:
Do we really need this error log for the whole record? It may eat up the
disk, imagine if znrecord is close to 1 MB. I am not sure if we really need the
record for troubleshooting. Maybe logging the instanceName, updateSubPath,
sessionId, etc. is good enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
